Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollout improved example converter #698

Merged
merged 7 commits into from
Apr 19, 2024
Merged

Rollout improved example converter #698

merged 7 commits into from
Apr 19, 2024

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Apr 16, 2024

Rolls out improved TF example converter.

Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

Copy link

Is README.md missing any configuration options?

No missing config!

@VenelinMartinov
Copy link
Contributor

Some dropped examples here:

AlpineRepository is dropped because of terraform in the resource name - should we be renaming that?

DistributionPublicKey is dropped and I can't see why.

@t0yv0
Copy link
Member Author

t0yv0 commented Apr 17, 2024

  "ExampleName": "#/resources/artifactory:index/alpineRepository:AlpineRepository",
  "OriginalHCL": "resource \"artifactory_keypair\" \"some-keypairRSA\" {\n  pair_name         = \"some-keypair\"\n  pair_type         = \"RSA\"\n  alias             = \"foo-alias\"\n  private_key       = file(\"samples/rsa.priv\")\n  public_key        = file(\"samples/rsa.pub\")\n  lifecycle {\n    ignore_changes  = [\n      private_key,\n      passphrase,\n    ]\n  }\n}\n\nresource \"artifactory_local_alpine_repository\" \"terraform-local-test-alpine-repo-basic\" {\n  key                 = \"terraform-local-test-alpine-repo-basic\"\n  primary_keypair_ref = artifactory_keypair.some-keypairRSA.pair_name\n\n  depends_on          = [artifactory_keypair.some-keypairRSA]\n}\n",
  "ConversionResults": {
    "csharp": {
      "FailureSeverity": 2,
      "FailureInfo": "pcl.BindProgram failed: example.pp:4,23-39: unknown package 'std'; unknown package 'std', and 1 other diagnostic(s)",
      "Program": "",
      "TranslationCount": 1
    },
    "go": {
      "FailureSeverity": 2,
      "FailureInfo": "pcl.BindProgram failed: example.pp:4,23-39: unknown package 'std'; unknown package 'std', and 1 other diagnostic(s)",
      "Program": "",
      "TranslationCount": 1
    },
    "java": {
      "FailureSeverity": 2,
      "FailureInfo": "pcl.BindProgram failed: example.pp:4,23-39: unknown package 'std'; unknown package 'std', and 1 other diagnostic(s)",
      "Program": "",
      "TranslationCount": 1
    },
    "python": {
      "FailureSeverity": 2,
      "FailureInfo": "pcl.BindProgram failed: example.pp:4,23-39: unknown package 'std'; unknown package 'std', and 1 other diagnostic(s)",
      "Program": "",
      "TranslationCount": 1
    },
    "typescript": {
      "FailureSeverity": 2,
      "FailureInfo": "pcl.BindProgram failed: example.pp:4,23-39: unknown package 'std'; unknown package 'std', and 1 other diagnostic(s)",
      "Program": "",
      "TranslationCount": 1
    },
    "yaml": {
      "FailureSeverity": 2,
      "FailureInfo": "pcl.BindProgram failed: example.pp:4,23-39: unknown package 'std'; unknown package 'std', and 1 other diagnostic(s)",
      "Program": "",
      "TranslationCount": 1
    }
  }
}

@t0yv0
Copy link
Member Author

t0yv0 commented Apr 17, 2024

I might need to add std package and rebuild.

@t0yv0
Copy link
Member Author

t0yv0 commented Apr 17, 2024

Both examples are back.

@t0yv0 t0yv0 requested review from VenelinMartinov and iwahbe April 17, 2024 15:40
@t0yv0 t0yv0 force-pushed the t0yv0/rollout-converter branch from 718ddee to cbaa86b Compare April 18, 2024 17:15
@t0yv0 t0yv0 merged commit 42c3c37 into main Apr 19, 2024
17 checks passed
@t0yv0 t0yv0 deleted the t0yv0/rollout-converter branch April 19, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants